net: decnet: dn_nsp_out: use swap macro in dn_mk_ack_header

Make use of the swap macro and remove unnecessary variable tmp.
This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/decnet/dn_nsp_out.c b/net/decnet/dn_nsp_out.c
index e50a4adfcf7e700385a5733478f3bddd22bbf017..56a52a004c560b674b7172fdf38de283d6dbb36e 100644 (file)
--- a/net/decnet/dn_nsp_out.c
+++ b/net/decnet/dn_nsp_out.c
@@ -313,11 +313,8 @@ static __le16 *dn_mk_ack_header(struct sock *sk, struct sk_buff *skb, unsigned c
        ackcrs |= 0x8000;
 
        /* If this is an "other data/ack" message, swap acknum and ackcrs */
-       if (other) {
-               unsigned short tmp = acknum;
-               acknum = ackcrs;
-               ackcrs = tmp;
-       }
+       if (other)
+               swap(acknum, ackcrs);
 
        /* Set "cross subchannel" bit in ackcrs */
        ackcrs |= 0x2000;