iscsi-target: Drop left-over iscsi_conn->bad_hdr

All REJECT response setup of the rejected payload is now done using
on-demand cmd->buf_ptr allocations.

Go ahead and remove dead iscsi_conn->bad_hdr usage rx_opcode path

Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
index f2c3d4abfe703555d577928d88b1e0357a78775d..dc2c0565736df1df58f3019eea4fa22f7805d9e5 100644 (file)
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -4105,11 +4105,6 @@ restart:
                        goto transport_err;
                }
 
-               /*
-                * Set conn->bad_hdr for use with REJECT PDUs.
-                */
-               memcpy(&conn->bad_hdr, &buffer, ISCSI_HDR_LEN);
-
                if (conn->conn_ops->HeaderDigest) {
                        iov.iov_base    = &digest;
                        iov.iov_len     = ISCSI_CRC_LEN;

diff --git a/drivers/target/iscsi/iscsi_target_core.h b/drivers/target/iscsi/iscsi_target_core.h
index 391283c853139639dcabcb97a858d06aaae25f67..caa0ad9a778ba8d19eafb4c97400b1c8e6888877 100644 (file)
--- a/drivers/target/iscsi/iscsi_target_core.h
+++ b/drivers/target/iscsi/iscsi_target_core.h
@@ -532,8 +532,6 @@ struct iscsi_conn {
        u32                     of_marker;
        /* Used for calculating OFMarker offset to next PDU */
        u32                     of_marker_offset;
-       /* Complete Bad PDU for sending reject */
-       unsigned char           bad_hdr[ISCSI_HDR_LEN];
 #define IPV6_ADDRESS_SPACE                             48
        unsigned char           login_ip[IPV6_ADDRESS_SPACE];
        unsigned char           local_ip[IPV6_ADDRESS_SPACE];