net: encx24j600: Fix mask to update LED configuration
authorJon Ringle <jringle@gridpoint.com>
Thu, 22 Oct 2015 19:09:04 +0000 (15:09 -0400)
committerDavid S. Miller <davem@davemloft.net>
Mon, 26 Oct 2015 01:23:45 +0000 (18:23 -0700)
This fixes the mask used to update the LED configuration so that it clears
the necessary bits as well as setting the bits according to the mask.
Also reverse the LED configuration to show the Link state + collisions in
LEDA and the Link state + TX/RX events in LEDB.

Signed-off-by: Jon Ringle <jringle@gridpoint.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/encx24j600.c

index e1329d9c2accb22b2ba93f5b14657f35da30bf71..bf08ce2baf8d1028ef44853f4a460aaecfd1ca5b 100644 (file)
@@ -617,10 +617,10 @@ static int encx24j600_hw_init(struct encx24j600_priv *priv)
                   (eidled & REVID_MASK) >> REVID_SHIFT);
 
        /* PHY Leds: link status,
-        * LEDA: Link + transmit/receive events
-        * LEDB: Link State + colision events
+        * LEDA: Link State + collision events
+        * LEDB: Link State + transmit/receive events
         */
-       encx24j600_update_reg(priv, EIDLED, 0xbc00, 0xbc00);
+       encx24j600_update_reg(priv, EIDLED, 0xff00, 0xcb00);
 
        /* Loopback disabled */
        encx24j600_write_reg(priv, MACON1, 0x9);