drm/i915: Print an error message for a reset failure on gen2
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 11 Dec 2017 20:40:40 +0000 (20:40 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 12 Dec 2017 21:07:40 +0000 (21:07 +0000)
Since on gen2, we do not universally have a GPU reset implementation, we
fail i915_reset() at intel_has_gpu_reset(). However, this is also
intentionally disabled for CI testing and so it only has a debug
message. Promote that debug message to a user-facing error message that
should explain why their machine became unusable following the GPU hang.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171211204040.22858-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_drv.c

index 54a8fca7e7b2847bea39613a1bce31ada35672fe..721ccce1832fcea49146d1c09525d37ee4e97c6f 100644 (file)
@@ -1903,7 +1903,10 @@ void i915_reset(struct drm_i915_private *i915, unsigned int flags)
        }
 
        if (!intel_has_gpu_reset(i915)) {
-               DRM_DEBUG_DRIVER("GPU reset disabled\n");
+               if (i915_modparams.reset)
+                       dev_err(i915->drm.dev, "GPU reset not supported\n");
+               else
+                       DRM_DEBUG_DRIVER("GPU reset disabled\n");
                goto error;
        }