mips/gup: Replace ACCESS_ONCE with READ_ONCE
authorChristian Borntraeger <borntraeger@de.ibm.com>
Fri, 21 Nov 2014 15:21:56 +0000 (16:21 +0100)
committerChristian Borntraeger <borntraeger@de.ibm.com>
Thu, 18 Dec 2014 08:54:39 +0000 (09:54 +0100)
ACCESS_ONCE does not work reliably on non-scalar types. For
example gcc 4.6 and 4.7 might remove the volatile tag for such
accesses during the SRA (scalar replacement of aggregates) step
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145)

Change the gup code to replace ACCESS_ONCE with READ_ONCE.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
arch/mips/mm/gup.c

index 06ce17c2a905af5be1bb9bae744d2f03abc64a6e..8aa50e3f3fce5b326b53c04c9163afdfa9abaeb4 100644 (file)
@@ -30,7 +30,7 @@ retry:
 
        return pte;
 #else
-       return ACCESS_ONCE(*ptep);
+       return READ_ONCE(*ptep);
 #endif
 }