usb: gadget: udc: lpc32xx: fix return value check in lpc32xx_udc_probe()

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

This issue was detected by using the Coccinelle software.

Fixes: 408b56ca5c8e ("usb: gadget: udc: lpc32xx: simplify probe")
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
index 2719194ebf425b73de9ac61f1d49035b2512644d..5f1b14f3e5a07ba0282cbf0ec56535e1aef95608 100644 (file)
--- a/drivers/usb/gadget/udc/lpc32xx_udc.c
+++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
@@ -3069,9 +3069,9 @@ static int lpc32xx_udc_probe(struct platform_device *pdev)
        }
 
        udc->udp_baseaddr = devm_ioremap_resource(dev, res);
-       if (!udc->udp_baseaddr) {
+       if (IS_ERR(udc->udp_baseaddr)) {
                dev_err(udc->dev, "IO map failure\n");
-               return -ENOMEM;
+               return PTR_ERR(udc->udp_baseaddr);
        }
 
        /* Get USB device clock */