Input: yealink - replace GFP_ATOMIC with GFP_KERNEL in usb_probe()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 18:34:13 +0000 (11:34 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 27 Jul 2018 18:59:09 +0000 (11:59 -0700)
usb_probe() is never called in atomic context.  It calls
usb_alloc_coherent() with GFP_ATOMIC, which is not necessary.  GFP_ATOMIC
can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/yealink.c

index f0c9bf87b4e381bbaa8c83d5887c803ac6515020..1365cd94ed9b17d6da99a5ede442930552892135 100644 (file)
@@ -894,12 +894,12 @@ static int usb_probe(struct usb_interface *intf, const struct usb_device_id *id)
 
        /* allocate usb buffers */
        yld->irq_data = usb_alloc_coherent(udev, USB_PKT_LEN,
-                                          GFP_ATOMIC, &yld->irq_dma);
+                                          GFP_KERNEL, &yld->irq_dma);
        if (yld->irq_data == NULL)
                return usb_cleanup(yld, -ENOMEM);
 
        yld->ctl_data = usb_alloc_coherent(udev, USB_PKT_LEN,
-                                          GFP_ATOMIC, &yld->ctl_dma);
+                                          GFP_KERNEL, &yld->ctl_dma);
        if (!yld->ctl_data)
                return usb_cleanup(yld, -ENOMEM);