net: hns3: fix a bug for phy supported feature initialization
authorFuyun Liang <liangfuyun1@huawei.com>
Fri, 3 Nov 2017 04:18:30 +0000 (12:18 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Nov 2017 12:36:50 +0000 (21:36 +0900)
This patch fixes a bug for phy supported feature initialization.
Currently, the value of phydev->supported is initialized by kernel.
So it includes many features that we do not support, such as
SUPPORTED_FIBRE and SUPPORTED_BNC. This patch fixes it.

Fixes: 256727d (net: hns3: Add MDIO support to HNS3 Ethernet driver for hip08 SoC)
Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Lipeng <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c

index f32d719c4f77a2bf4dfd00896250aa27cc29f78c..7069e9408d7de58b164293480c9bd75fa5eae3cf 100644 (file)
 #include "hclge_main.h"
 #include "hclge_mdio.h"
 
+#define HCLGE_PHY_SUPPORTED_FEATURES   (SUPPORTED_Autoneg | \
+                                        SUPPORTED_TP | \
+                                        SUPPORTED_Pause | \
+                                        PHY_10BT_FEATURES | \
+                                        PHY_100BT_FEATURES | \
+                                        PHY_1000BT_FEATURES)
+
 enum hclge_mdio_c22_op_seq {
        HCLGE_MDIO_C22_WRITE = 1,
        HCLGE_MDIO_C22_READ = 2
@@ -195,6 +202,9 @@ int hclge_mac_start_phy(struct hclge_dev *hdev)
                return ret;
        }
 
+       phydev->supported &= HCLGE_PHY_SUPPORTED_FEATURES;
+       phydev->advertising = phydev->supported;
+
        phy_start(phydev);
 
        return 0;