wil6210: let IP stack re-check HW TCP/UDP csum errors

Fix for TCP iperf from Windows to Linux stall after about 1sec

Hardware reports false errors in some situations:

Microsoft IP stack, in violation of RFC 1624, set TCP checksum that should be 0x0
as 0xffff. hardware report Rx csum error. If HW csum absolutely trusted,
this frame can be never received, as re-transmitted one will have same csum problem.
In addition, it mess up block ack reorder buffer, as if packet dropped, it is not score boarded
there.

Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c
index ea1abeb18e5be8ef0045c3f41f6da287714d9b9c..d505b2676a736381366652e6815891286e6fe319 100644 (file)
--- a/drivers/net/wireless/ath/wil6210/txrx.c
+++ b/drivers/net/wireless/ath/wil6210/txrx.c
@@ -416,13 +416,13 @@ static struct sk_buff *wil_vring_reap_rx(struct wil6210_priv *wil,
         */
        if (d->dma.status & RX_DMA_STATUS_L4_IDENT) {
                /* L4 protocol identified, csum calculated */
-               if ((d->dma.error & RX_DMA_ERROR_L4_ERR) == 0) {
+               if ((d->dma.error & RX_DMA_ERROR_L4_ERR) == 0)
                        skb->ip_summed = CHECKSUM_UNNECESSARY;
-               } else {
-                       wil_err(wil, "Incorrect checksum reported\n");
-                       kfree_skb(skb);
-                       return NULL;
-               }
+               /* If HW reports bad checksum, let IP stack re-check it
+                * For example, HW don't understand Microsoft IP stack that
+                * mis-calculates TCP checksum - if it should be 0x0,
+                * it writes 0xffff in violation of RFC 1624
+                */
        }
 
        ds_bits = wil_rxdesc_ds_bits(d);