spi: spi-s3c64xx: Do not ignore timeout errors in polling I/O mode
authorSylwester Nawrocki <s.nawrocki@samsung.com>
Mon, 16 Apr 2018 15:40:19 +0000 (17:40 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 17 Apr 2018 10:46:52 +0000 (11:46 +0100)
Currently timeout errors in polling I/O mode transfer are silently ignored.
Fix it by returning an error when we time out waiting on the RX FIFO level
to reach the transfer length.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Reviewed-by: Andi Shyti <andi@etezian.org>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-s3c64xx.c

index b7333a8834421889581b77bd2efc2838ccc4901c..4c27426bcb407810be2b2c2a6451f3e2d8e07ea3 100644 (file)
@@ -503,6 +503,8 @@ static int wait_for_pio(struct s3c64xx_spi_driver_data *sdd,
                status = readl(regs + S3C64XX_SPI_STATUS);
        } while (RX_FIFO_LVL(status, sdd) < xfer->len && --val);
 
+       if (!val)
+               return -EIO;
 
        /* If it was only Tx */
        if (!xfer->rx_buf) {