drm/i915: Introduce intel_encoder_is_dig_port()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 5 Jul 2018 16:43:51 +0000 (19:43 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 13 Jul 2018 15:22:21 +0000 (18:22 +0300)
Add intel_encoder_is_dig_port() to match intel_encoder_is_dp().

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180705164357.28512-3-ville.syrjala@linux.intel.com
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/intel_drv.h

index 2740a0ef3f497043cd201762d75dd18a5c65bab0..987fbb2ef911ea43ff95b72dfdc2a4096d64e792 100644 (file)
@@ -1245,23 +1245,29 @@ intel_attached_encoder(struct drm_connector *connector)
        return to_intel_connector(connector)->encoder;
 }
 
-static inline struct intel_digital_port *
-enc_to_dig_port(struct drm_encoder *encoder)
+static inline bool intel_encoder_is_dig_port(struct intel_encoder *encoder)
 {
-       struct intel_encoder *intel_encoder = to_intel_encoder(encoder);
-
-       switch (intel_encoder->type) {
+       switch (encoder->type) {
        case INTEL_OUTPUT_DDI:
-               WARN_ON(!HAS_DDI(to_i915(encoder->dev)));
-               /* fall through */
        case INTEL_OUTPUT_DP:
        case INTEL_OUTPUT_EDP:
        case INTEL_OUTPUT_HDMI:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static inline struct intel_digital_port *
+enc_to_dig_port(struct drm_encoder *encoder)
+{
+       struct intel_encoder *intel_encoder = to_intel_encoder(encoder);
+
+       if (intel_encoder_is_dig_port(intel_encoder))
                return container_of(encoder, struct intel_digital_port,
                                    base.base);
-       default:
+       else
                return NULL;
-       }
 }
 
 static inline struct intel_dp_mst_encoder *