powerpc: Fix HMIs on big-endian with CONFIG_RELOCATABLE=y
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Mon, 8 Oct 2018 04:08:31 +0000 (15:08 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Sat, 22 Dec 2018 10:43:55 +0000 (21:43 +1100)
HMIs will crash the kernel due to

BRANCH_LINK_TO_FAR(hmi_exception_realmode)

Calling into the OPD instead of the actual code.

Fixes: 2337d207288f ("powerpc/64: CONFIG_RELOCATABLE support for hmi interrupts")
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
[mpe: Use DOTSYM() rather than #ifdef]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/exceptions-64s.S

index 89d32bb79d5eeb91520e78364bca1590f7b265b1..ed3d6fa8be53b27efa489d75ad133fbb8422d8f6 100644 (file)
@@ -1031,7 +1031,7 @@ TRAMP_REAL_BEGIN(hmi_exception_early)
        EXCEPTION_PROLOG_COMMON_2(PACA_EXGEN)
        EXCEPTION_PROLOG_COMMON_3(0xe60)
        addi    r3,r1,STACK_FRAME_OVERHEAD
-       BRANCH_LINK_TO_FAR(hmi_exception_realmode) /* Function call ABI */
+       BRANCH_LINK_TO_FAR(DOTSYM(hmi_exception_realmode)) /* Function call ABI */
        cmpdi   cr0,r3,0
 
        /* Windup the stack. */