RDMA/mlx5: Use proper allocation API to get zeroed memory
authorLeon Romanovsky <leonro@mellanox.com>
Sun, 30 Jun 2019 15:48:32 +0000 (18:48 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 4 Jul 2019 17:08:18 +0000 (14:08 -0300)
There is no need in custom memory zeroing, because it can be done
by using kzalloc from the beginning.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/mlx5/main.c

index 692b60898ee25575cbc884c793cee269ed93170e..1af36497d54c171a13856719a9788e3e40c31d44 100644 (file)
@@ -4726,7 +4726,7 @@ static int __get_port_caps(struct mlx5_ib_dev *dev, u8 port)
        int err = -ENOMEM;
        struct ib_udata uhw = {.inlen = 0, .outlen = 0};
 
-       pprops = kmalloc(sizeof(*pprops), GFP_KERNEL);
+       pprops = kzalloc(sizeof(*pprops), GFP_KERNEL);
        if (!pprops)
                goto out;
 
@@ -4740,7 +4740,6 @@ static int __get_port_caps(struct mlx5_ib_dev *dev, u8 port)
                goto out;
        }
 
-       memset(pprops, 0, sizeof(*pprops));
        err = mlx5_ib_query_port(&dev->ib_dev, port, pprops);
        if (err) {
                mlx5_ib_warn(dev, "query_port %d failed %d\n",