KVM: PPC: Book3S HV: Add of_node_put() in success path
authorNicholas Mc Guire <hofrat@osadl.org>
Sat, 7 Jul 2018 06:53:07 +0000 (08:53 +0200)
committerPaul Mackerras <paulus@ozlabs.org>
Wed, 18 Jul 2018 05:14:45 +0000 (15:14 +1000)
The call to of_find_compatible_node() is returning a pointer with
incremented refcount so it must be explicitly decremented after the
last use. As here it is only being used for checking of node presence
but the result is not actually used in the success path it can be
dropped immediately.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: commit f725758b899f ("KVM: PPC: Book3S HV: Use OPAL XICS emulation on POWER9")
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
arch/powerpc/kvm/book3s_hv.c

index de686b340f4aa4ccccaf47e3349eba94d6fddda2..fba21c91b2ffd5a9c9754c900db6c295d5a058dd 100644 (file)
@@ -4561,6 +4561,8 @@ static int kvmppc_book3s_init_hv(void)
                        pr_err("KVM-HV: Cannot determine method for accessing XICS\n");
                        return -ENODEV;
                }
+               /* presence of intc confirmed - node can be dropped again */
+               of_node_put(np);
        }
 #endif