i2c: stu300: use core to detect 'no zero length' quirk
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 23 Jul 2018 20:26:11 +0000 (22:26 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Sat, 4 Aug 2018 21:25:07 +0000 (23:25 +0200)
And don't reimplement in the driver.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-stu300.c

index fce52bdab2b715a7123e34b153e2206662c67bf9..5503fa171df0dbd3ef73d0e63852d8931f4d47a3 100644 (file)
@@ -673,12 +673,6 @@ static int stu300_xfer_msg(struct i2c_adapter *adap,
                        msg->addr, msg->len, msg->flags, stop);
        }
 
-       /* Zero-length messages are not supported by this hardware */
-       if (msg->len == 0) {
-               ret = -EINVAL;
-               goto exit_disable;
-       }
-
        /*
         * For some reason, sending the address sometimes fails when running
         * on  the 13 MHz clock. No interrupt arrives. This is a work around,
@@ -863,6 +857,10 @@ static const struct i2c_algorithm stu300_algo = {
        .functionality  = stu300_func,
 };
 
+static const struct i2c_adapter_quirks stu300_quirks = {
+       .flags = I2C_AQ_NO_ZERO_LEN,
+};
+
 static int stu300_probe(struct platform_device *pdev)
 {
        struct stu300_dev *dev;
@@ -920,6 +918,8 @@ static int stu300_probe(struct platform_device *pdev)
        adap->algo = &stu300_algo;
        adap->dev.parent = &pdev->dev;
        adap->dev.of_node = pdev->dev.of_node;
+       adap->quirks = &stu300_quirks;
+
        i2c_set_adapdata(adap, dev);
 
        /* i2c device drivers may be active on return from add_adapter() */