Input: aiptek - replace GFP_ATOMIC with GFP_KERNEL in aiptek_probe()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 18:35:17 +0000 (11:35 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 27 Jul 2018 18:59:10 +0000 (11:59 -0700)
aiptek_probe() is never called in atomic context. It calls
usb_alloc_coherent() with GFP_ATOMIC, which is not necessary. GFP_ATOMIC
can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/tablet/aiptek.c

index 545fa6e890354f4ad8d5cac6384849da70f8017e..c82cd5079d0e6207cc22a6ed5f2155f2e6d156e2 100644 (file)
@@ -1712,7 +1712,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
         }
 
        aiptek->data = usb_alloc_coherent(usbdev, AIPTEK_PACKET_LENGTH,
-                                         GFP_ATOMIC, &aiptek->data_dma);
+                                         GFP_KERNEL, &aiptek->data_dma);
         if (!aiptek->data) {
                dev_warn(&intf->dev, "cannot allocate usb buffer\n");
                goto fail1;