lightnvm: pblk: remove some unnecessary NULL checks

Smatch complains that flush_workqueue() dereferences the work queue
pointer but then we check if it's NULL on the next line when it's too
late.  These NULL checks can be removed because the module won't load if
we can't allocate the work queues.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c
index 7143b0f740fb699ceca025e181dd3c2a5fe9ebac..6851a5c6718910af85cf57783c4de3e371dd26a7 100644 (file)
--- a/drivers/lightnvm/pblk-gc.c
+++ b/drivers/lightnvm/pblk-gc.c
@@ -664,12 +664,10 @@ void pblk_gc_exit(struct pblk *pblk)
                kthread_stop(gc->gc_reader_ts);
 
        flush_workqueue(gc->gc_reader_wq);
-       if (gc->gc_reader_wq)
-               destroy_workqueue(gc->gc_reader_wq);
+       destroy_workqueue(gc->gc_reader_wq);
 
        flush_workqueue(gc->gc_line_reader_wq);
-       if (gc->gc_line_reader_wq)
-               destroy_workqueue(gc->gc_line_reader_wq);
+       destroy_workqueue(gc->gc_line_reader_wq);
 
        if (gc->gc_writer_ts)
                kthread_stop(gc->gc_writer_ts);