serial: imx: Fix out-of-bounds access through serial port index

The imx_ports[] array is indexed using a value derived from the
"serialN" alias in DT, or from platform data, which may lead to an
out-of-bounds access.

Fix this by adding a range check.

Fixes: ff05967a07225ab6 ("serial/imx: add of_alias_get_id() reference back")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 689a117943a000da6de7ba998fb810b444d4ba67..78bacd020221a33cd97db53a47f9c123828fba87 100644 (file)
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2069,6 +2069,12 @@ static int serial_imx_probe(struct platform_device *pdev)
        else if (ret < 0)
                return ret;
 
+       if (sport->port.line >= ARRAY_SIZE(imx_ports)) {
+               dev_err(&pdev->dev, "serial%d out of range\n",
+                       sport->port.line);
+               return -EINVAL;
+       }
+
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        base = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(base))