net: hns3: Fix for l4 checksum offload bug

Hardware only support tcp/udp/sctp l4 checksum offload, but
the driver currently tell hardware to do l4 checksum offlad when
l3 is IPv4 or IPv6, which may cause checksumm error.

This patch fixes it by only enabling the l4 offload when l4 is
tcp/udp/sctp.

Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index e5e51e801c383033bf1a7a760c3ca037d968d470..c211450bfd781f07c676560d5c1660927b3f2d60 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -791,16 +791,14 @@ static int hns3_set_l3l4_type_csum(struct sk_buff *skb, u8 ol4_proto,
                 */
                if (skb_is_gso(skb))
                        hnae3_set_bit(*type_cs_vlan_tso, HNS3_TXD_L3CS_B, 1);
-
-               hnae3_set_bit(*type_cs_vlan_tso, HNS3_TXD_L4CS_B, 1);
        } else if (l3.v6->version == 6) {
                hnae3_set_field(*type_cs_vlan_tso, HNS3_TXD_L3T_M,
                                HNS3_TXD_L3T_S, HNS3_L3T_IPV6);
-               hnae3_set_bit(*type_cs_vlan_tso, HNS3_TXD_L4CS_B, 1);
        }
 
        switch (l4_proto) {
        case IPPROTO_TCP:
+               hnae3_set_bit(*type_cs_vlan_tso, HNS3_TXD_L4CS_B, 1);
                hnae3_set_field(*type_cs_vlan_tso,
                                HNS3_TXD_L4T_M,
                                HNS3_TXD_L4T_S,
@@ -810,12 +808,14 @@ static int hns3_set_l3l4_type_csum(struct sk_buff *skb, u8 ol4_proto,
                if (hns3_tunnel_csum_bug(skb))
                        break;
 
+               hnae3_set_bit(*type_cs_vlan_tso, HNS3_TXD_L4CS_B, 1);
                hnae3_set_field(*type_cs_vlan_tso,
                                HNS3_TXD_L4T_M,
                                HNS3_TXD_L4T_S,
                                HNS3_L4T_UDP);
                break;
        case IPPROTO_SCTP:
+               hnae3_set_bit(*type_cs_vlan_tso, HNS3_TXD_L4CS_B, 1);
                hnae3_set_field(*type_cs_vlan_tso,
                                HNS3_TXD_L4T_M,
                                HNS3_TXD_L4T_S,