drm/vc4: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Jun 2019 11:45:48 +0000 (13:45 +0200)
committerEric Anholt <eric@anholt.net>
Fri, 14 Jun 2019 23:21:45 +0000 (16:21 -0700)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Reviewed-by: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190613114548.GC13119@kroah.com
drivers/gpu/drm/vc4/vc4_debugfs.c

index f9dec08267dc7a7e8957aca514388c50633b7f9d..f9b46911fa50c5096a59c3bf1d66f02dc89db349 100644 (file)
@@ -29,13 +29,9 @@ vc4_debugfs_init(struct drm_minor *minor)
 {
        struct vc4_dev *vc4 = to_vc4_dev(minor->dev);
        struct vc4_debugfs_info_entry *entry;
-       struct dentry *dentry;
 
-       dentry = debugfs_create_bool("hvs_load_tracker", S_IRUGO | S_IWUSR,
-                                    minor->debugfs_root,
-                                    &vc4->load_tracker_enabled);
-       if (!dentry)
-               return -ENOMEM;
+       debugfs_create_bool("hvs_load_tracker", S_IRUGO | S_IWUSR,
+                           minor->debugfs_root, &vc4->load_tracker_enabled);
 
        list_for_each_entry(entry, &vc4->debugfs_list, link) {
                int ret = drm_debugfs_create_files(&entry->info, 1,