Revert "net: phylink: set the autoneg state in phylink_phy_change"
authorDavid S. Miller <davem@davemloft.net>
Sun, 16 Jun 2019 01:10:30 +0000 (18:10 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 16 Jun 2019 01:10:30 +0000 (18:10 -0700)
This reverts commit ef7bfa84725d891bbdb88707ed55b2cbf94942bb.

Russell King espressed some strong opposition to this
change, explaining that this is trying to make phylink
behave outside of how it has been designed.

Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phylink.c

index c638e13fbf81d5c447b1751823baebb65a634929..4c0616ba314d37048baba87bfdec125d9abd1114 100644 (file)
@@ -635,7 +635,6 @@ static void phylink_phy_change(struct phy_device *phydev, bool up,
                pl->phy_state.pause |= MLO_PAUSE_ASYM;
        pl->phy_state.interface = phydev->interface;
        pl->phy_state.link = up;
-       pl->phy_state.an_enabled = phydev->autoneg;
        mutex_unlock(&pl->state_mutex);
 
        phylink_run_resolve(pl);