mtd: rawnand: Kill cafe_nand_bug()
authorBoris Brezillon <boris.brezillon@bootlin.com>
Thu, 5 Jul 2018 10:27:26 +0000 (12:27 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 18 Jul 2018 07:34:20 +0000 (09:34 +0200)
Leaving a function pointer to NULL should be enough to trigger a NULL
pointer exception, and anyway, if we want to BUG() when some missing
hooks are called, this should be done in the core, so let's drop the
cafe_nand_bug() dummy function.

Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/cafe_nand.c

index d721f489b38bcd07a9141782c5942e93d99e727f..ac0be933a4907776d2e0a2473ccb260b778ec27b 100644 (file)
@@ -345,11 +345,6 @@ static irqreturn_t cafe_nand_interrupt(int irq, void *id)
        return IRQ_HANDLED;
 }
 
-static void cafe_nand_bug(struct mtd_info *mtd)
-{
-       BUG();
-}
-
 static int cafe_nand_write_oob(struct mtd_info *mtd,
                               struct nand_chip *chip, int page)
 {
@@ -760,9 +755,6 @@ static int cafe_nand_probe(struct pci_dev *pdev,
        cafe->nand.ecc.size = mtd->writesize;
        cafe->nand.ecc.bytes = 14;
        cafe->nand.ecc.strength = 4;
-       cafe->nand.ecc.hwctl  = (void *)cafe_nand_bug;
-       cafe->nand.ecc.calculate = (void *)cafe_nand_bug;
-       cafe->nand.ecc.correct  = (void *)cafe_nand_bug;
        cafe->nand.ecc.write_page = cafe_nand_write_page_lowlevel;
        cafe->nand.ecc.write_oob = cafe_nand_write_oob;
        cafe->nand.ecc.read_page = cafe_nand_read_page;