drm/amd/pp: Fix NULL point check error in smu_set_watermarks_for_clocks_ranges
authorRex Zhu <Rex.Zhu@amd.com>
Thu, 19 Apr 2018 04:40:15 +0000 (12:40 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 15 May 2018 18:43:33 +0000 (13:43 -0500)
It is caused by
'commit d6c9a7dc86cd ("drm/amd/pp: Move common code to smu_helper.c")'

Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c

index 7c23741619b6b1f5e95e5ad5bbbf627f1618202b..93a3d022ba47a7d6a20cc7a1f8b763bf3eb58b06 100644 (file)
@@ -657,7 +657,7 @@ int smu_set_watermarks_for_clocks_ranges(void *wt_table,
        uint32_t i;
        struct watermarks *table = wt_table;
 
-       if (!table || wm_with_clock_ranges)
+       if (!table || !wm_with_clock_ranges)
                return -EINVAL;
 
        if (wm_with_clock_ranges->num_wm_sets_dmif > 4 || wm_with_clock_ranges->num_wm_sets_mcif > 4)