btrfs: cleanup iterating over prop_handlers array
authorByongho Lee <bhlee.kernel@gmail.com>
Thu, 8 Oct 2015 11:49:34 +0000 (20:49 +0900)
committerDavid Sterba <dsterba@suse.com>
Wed, 21 Oct 2015 16:28:48 +0000 (18:28 +0200)
This patch eliminates the last item of prop_handlers array which is used
to check end of array and instead uses ARRAY_SIZE macro.
Though this is a very tiny optimization, using ARRAY_SIZE macro is a
good practice to iterate array.

Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: Byongho Lee <bhlee.kernel@gmail.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/props.c

index dca137b04095fc509390b2c02d4ca6ad1752ee74..f9e60231f6854545d514d8df53b8ba21be92762e 100644 (file)
@@ -49,18 +49,16 @@ static struct prop_handler prop_handlers[] = {
                .extract = prop_compression_extract,
                .inheritable = 1
        },
-       {
-               .xattr_name = NULL
-       }
 };
 
 void __init btrfs_props_init(void)
 {
-       struct prop_handler *p;
+       int i;
 
        hash_init(prop_handlers_ht);
 
-       for (p = &prop_handlers[0]; p->xattr_name; p++) {
+       for (i = 0; i < ARRAY_SIZE(prop_handlers); i++) {
+               struct prop_handler *p = &prop_handlers[i];
                u64 h = btrfs_name_hash(p->xattr_name, strlen(p->xattr_name));
 
                hash_add(prop_handlers_ht, &p->node, h);
@@ -301,15 +299,16 @@ static int inherit_props(struct btrfs_trans_handle *trans,
                         struct inode *inode,
                         struct inode *parent)
 {
-       const struct prop_handler *h;
        struct btrfs_root *root = BTRFS_I(inode)->root;
        int ret;
+       int i;
 
        if (!test_bit(BTRFS_INODE_HAS_PROPS,
                      &BTRFS_I(parent)->runtime_flags))
                return 0;
 
-       for (h = &prop_handlers[0]; h->xattr_name; h++) {
+       for (i = 0; i < ARRAY_SIZE(prop_handlers); i++) {
+               const struct prop_handler *h = &prop_handlers[i];
                const char *value;
                u64 num_bytes;