drm/amd/display: small cleanup in destruct()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 6 Nov 2017 07:07:33 +0000 (10:07 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 7 Nov 2017 21:21:39 +0000 (16:21 -0500)
Static analysis tools get annoyed that we don't indent this if
statement.  Actually, the if statement isn't required because kfree()
can handle NULL pointers just fine.  The DCE110STRENC_FROM_STRENC()
macro is a wrapper around container_of() but it's basically a no-op or a
cast.  Anyway, it's not really appropriate here so it should be removed
as well.

Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_resource.c

index d911590d08bc4922cc22cac0b7808c2d62e409a1..4c4bd72d4e405ad24e61760828fc3d7c7e439dd3 100644 (file)
@@ -725,10 +725,8 @@ static void destruct(struct dcn10_resource_pool *pool)
                }
        }
 
-       for (i = 0; i < pool->base.stream_enc_count; i++) {
-               if (pool->base.stream_enc[i] != NULL)
-               kfree(DCE110STRENC_FROM_STRENC(pool->base.stream_enc[i]));
-       }
+       for (i = 0; i < pool->base.stream_enc_count; i++)
+               kfree(pool->base.stream_enc[i]);
 
        for (i = 0; i < pool->base.audio_count; i++) {
                if (pool->base.audios[i])