drm/blend: Use new atomic iterator macros.
authorMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Thu, 16 Feb 2017 14:47:10 +0000 (15:47 +0100)
committerMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Mon, 6 Mar 2017 10:43:43 +0000 (11:43 +0100)
There are new iterator macros that annotate whether the new or old
state should be used. This is better than using a state that depends on
whether it's called before or after swap. For clarity, also rename the
variables from $obj_state to (old,new)_$obj_state as well.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1487256430-7625-6-git-send-email-maarten.lankhorst@linux.intel.com
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/gpu/drm/drm_blend.c

index d7053bb67db65ade4c2860c68adb6bb61688f65b..a0d0d684328822d7166f881b3470700a49a870f1 100644 (file)
@@ -377,26 +377,26 @@ int drm_atomic_normalize_zpos(struct drm_device *dev,
                              struct drm_atomic_state *state)
 {
        struct drm_crtc *crtc;
-       struct drm_crtc_state *crtc_state;
+       struct drm_crtc_state *old_crtc_state, *new_crtc_state;
        struct drm_plane *plane;
-       struct drm_plane_state *plane_state;
+       struct drm_plane_state *old_plane_state, *new_plane_state;
        int i, ret = 0;
 
-       for_each_plane_in_state(state, plane, plane_state, i) {
-               crtc = plane_state->crtc;
+       for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) {
+               crtc = new_plane_state->crtc;
                if (!crtc)
                        continue;
-               if (plane->state->zpos != plane_state->zpos) {
-                       crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
-                       crtc_state->zpos_changed = true;
+               if (old_plane_state->zpos != new_plane_state->zpos) {
+                       new_crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
+                       new_crtc_state->zpos_changed = true;
                }
        }
 
-       for_each_crtc_in_state(state, crtc, crtc_state, i) {
-               if (crtc_state->plane_mask != crtc->state->plane_mask ||
-                   crtc_state->zpos_changed) {
+       for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
+               if (old_crtc_state->plane_mask != new_crtc_state->plane_mask ||
+                   new_crtc_state->zpos_changed) {
                        ret = drm_atomic_helper_crtc_normalize_zpos(crtc,
-                                                                   crtc_state);
+                                                                   new_crtc_state);
                        if (ret)
                                return ret;
                }