drm/sun4i: dsi: Rework a bit the hblk calculation

It turns out that the hblk calculation actually follows a similar pattern
than the other packets. Rework a bit the calculation and add a comment.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/d79a21b09847579ce907212a59737af21a729dd0.1549896081.git-series.maxime.ripard@bootlin.com

diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
index 9357266961315091109f00a53526434de5595b54..d7c14758d30cc1ca03a5e5a91b31d91c9d9c640b 100644 (file)
--- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
+++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
@@ -489,9 +489,13 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,
                  (mode->hsync_start - mode->hdisplay) * Bpp - HFP_PACKET_OVERHEAD);
 
        /*
-        * hblk seems to be the line + porches length.
+        * The blanking is set using a sync event (4 bytes) and a
+        * blanking packet (4 bytes + payload + 2 bytes). Its minimal
+        * size is therefore 10 bytes.
         */
-       hblk = mode->htotal * Bpp - hsa;
+#define HBLK_PACKET_OVERHEAD   10
+       hblk = max((unsigned int)HBLK_PACKET_OVERHEAD,
+                  (mode->htotal - (mode->hsync_end - mode->hsync_start)) * Bpp - HBLK_PACKET_OVERHEAD);
 
        /*
         * And I'm not entirely sure what vblk is about. The driver in