block: Remove redundant WARN_ON()
authorAnna-Maria Gleixner <anna-maria@linutronix.de>
Fri, 4 May 2018 14:32:46 +0000 (16:32 +0200)
committerJens Axboe <axboe@kernel.dk>
Mon, 7 May 2018 21:26:36 +0000 (15:26 -0600)
Commit 2fff8a924d4c ("block: Check locking assumptions at runtime") added a
lockdep_assert_held(q->queue_lock) which makes the WARN_ON() redundant
because lockdep will detect and warn about context violations.

The unconditional WARN_ON() does not provide real additional value, so it
can be removed.

Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-core.c

index 85909b431eb0d52d5f29633fcb2ccfff0b14d9e0..a3caccaa7d1f57214540999052099d276209379b 100644 (file)
@@ -360,7 +360,6 @@ EXPORT_SYMBOL(blk_start_queue_async);
 void blk_start_queue(struct request_queue *q)
 {
        lockdep_assert_held(q->queue_lock);
-       WARN_ON(!in_interrupt() && !irqs_disabled());
        WARN_ON_ONCE(q->mq_ops);
 
        queue_flag_clear(QUEUE_FLAG_STOPPED, q);