Revert ("r8169: remove 1000/Half from supported modes")
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 27 Jul 2019 10:32:28 +0000 (12:32 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 27 Jul 2019 21:29:25 +0000 (14:29 -0700)
This reverts commit a6851c613fd7fccc5d1f28d5d8a0cbe9b0f4e8cc.
It was reported that RTL8111b successfully finishes 1000/Full autoneg
but no data flows. Reverting the original patch fixes the issue.
It seems to be a HW issue with the integrated RTL8211B PHY. This PHY
version used also e.g. on RTL8168d, so better revert the original patch.

Reported-by: Bernhard Held <berny156@gmx.de>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index 6272115b28480a55b081bd2c52ec051791835786..a71dd669a728226629c03007fdf68073f9f8597c 100644 (file)
@@ -6136,10 +6136,7 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
        if (ret)
                return ret;
 
-       if (tp->supports_gmii)
-               phy_remove_link_mode(phydev,
-                                    ETHTOOL_LINK_MODE_1000baseT_Half_BIT);
-       else
+       if (!tp->supports_gmii)
                phy_set_max_speed(phydev, SPEED_100);
 
        phy_support_asym_pause(phydev);