net: hns3: Check variable is valid before assigning it to another

In hnae3_register_ae_dev(), ae_algo->ops is assigned to ae_dev->ops
before check that ae_algo->ops is valid.

And in hnae3_register_ae_algo(), missing check for ae_algo->ops.

This patch fixes them.

Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.c b/drivers/net/ethernet/hisilicon/hns3/hnae3.c
index 9f5349b9243f39876a531186813510dca48a613b..17ab4f4af6ad52259e3d0311ed2c751271579af7 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns3/hnae3.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hnae3.c
@@ -185,8 +185,12 @@ void hnae3_register_ae_algo(struct hnae3_ae_algo *ae_algo)
                if (!id)
                        continue;
 
-               /* ae_dev init should set flag */
+               if (!ae_algo->ops) {
+                       dev_err(&ae_dev->pdev->dev, "ae_algo ops are null\n");
+                       continue;
+               }
                ae_dev->ops = ae_algo->ops;
+
                ret = ae_algo->ops->init_ae_dev(ae_dev);
                if (ret) {
                        dev_err(&ae_dev->pdev->dev,
@@ -194,6 +198,7 @@ void hnae3_register_ae_algo(struct hnae3_ae_algo *ae_algo)
                        continue;
                }
 
+               /* ae_dev init should set flag */
                hnae3_set_bit(ae_dev->flag, HNAE3_DEV_INITED_B, 1);
 
                /* check the client list for the match with this ae_dev type and
@@ -273,15 +278,13 @@ int hnae3_register_ae_dev(struct hnae3_ae_dev *ae_dev)
                if (!id)
                        continue;
 
-               ae_dev->ops = ae_algo->ops;
-
-               if (!ae_dev->ops) {
-                       dev_err(&ae_dev->pdev->dev, "ae_dev ops are null\n");
+               if (!ae_algo->ops) {
+                       dev_err(&ae_dev->pdev->dev, "ae_algo ops are null\n");
                        ret = -EOPNOTSUPP;
                        goto out_err;
                }
+               ae_dev->ops = ae_algo->ops;
 
-               /* ae_dev init should set flag */
                ret = ae_dev->ops->init_ae_dev(ae_dev);
                if (ret) {
                        dev_err(&ae_dev->pdev->dev,
@@ -289,6 +292,7 @@ int hnae3_register_ae_dev(struct hnae3_ae_dev *ae_dev)
                        goto out_err;
                }
 
+               /* ae_dev init should set flag */
                hnae3_set_bit(ae_dev->flag, HNAE3_DEV_INITED_B, 1);
                break;
        }