arm64: KVM: Use per-CPU vector when BP hardening is enabled
authorMarc Zyngier <marc.zyngier@arm.com>
Wed, 3 Jan 2018 16:38:35 +0000 (16:38 +0000)
committerCatalin Marinas <catalin.marinas@arm.com>
Mon, 8 Jan 2018 18:46:56 +0000 (18:46 +0000)
Now that we have per-CPU vectors, let's plug then in the KVM/arm64 code.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm/include/asm/kvm_mmu.h
arch/arm64/include/asm/kvm_mmu.h
arch/arm64/kvm/hyp/switch.c
virt/kvm/arm/arm.c

index 8c5643e2eea49b8c987cb88f695596c9d8c5bc50..a2d176a308bd63ed4aeb89b8fda4f5b8a20b8a88 100644 (file)
@@ -226,6 +226,16 @@ static inline unsigned int kvm_get_vmid_bits(void)
        return 8;
 }
 
+static inline void *kvm_get_hyp_vector(void)
+{
+       return kvm_ksym_ref(__kvm_hyp_vector);
+}
+
+static inline int kvm_map_vectors(void)
+{
+       return 0;
+}
+
 #define kvm_phys_to_vttbr(addr)                (addr)
 
 #endif /* !__ASSEMBLY__ */
index b33bdb5eeb3d3ea29daa5d5cc41c62da0315c5d8..72e279dbae5f4db1201cd2bfd28be8cc7dd46e1f 100644 (file)
@@ -322,6 +322,44 @@ static inline unsigned int kvm_get_vmid_bits(void)
        return (cpuid_feature_extract_unsigned_field(reg, ID_AA64MMFR1_VMIDBITS_SHIFT) == 2) ? 16 : 8;
 }
 
+#ifdef CONFIG_HARDEN_BRANCH_PREDICTOR
+#include <asm/mmu.h>
+
+static inline void *kvm_get_hyp_vector(void)
+{
+       struct bp_hardening_data *data = arm64_get_bp_hardening_data();
+       void *vect = kvm_ksym_ref(__kvm_hyp_vector);
+
+       if (data->fn) {
+               vect = __bp_harden_hyp_vecs_start +
+                      data->hyp_vectors_slot * SZ_2K;
+
+               if (!has_vhe())
+                       vect = lm_alias(vect);
+       }
+
+       return vect;
+}
+
+static inline int kvm_map_vectors(void)
+{
+       return create_hyp_mappings(kvm_ksym_ref(__bp_harden_hyp_vecs_start),
+                                  kvm_ksym_ref(__bp_harden_hyp_vecs_end),
+                                  PAGE_HYP_EXEC);
+}
+
+#else
+static inline void *kvm_get_hyp_vector(void)
+{
+       return kvm_ksym_ref(__kvm_hyp_vector);
+}
+
+static inline int kvm_map_vectors(void)
+{
+       return 0;
+}
+#endif
+
 #define kvm_phys_to_vttbr(addr)                phys_to_ttbr(addr)
 
 #endif /* __ASSEMBLY__ */
index f7c651f3a8c0e8001bb11b1a45216ac6d4a6b342..8d4f3c9d6dc43a56a7e708e6f52d6a3d49f39513 100644 (file)
@@ -52,7 +52,7 @@ static void __hyp_text __activate_traps_vhe(void)
        val &= ~(CPACR_EL1_FPEN | CPACR_EL1_ZEN);
        write_sysreg(val, cpacr_el1);
 
-       write_sysreg(__kvm_hyp_vector, vbar_el1);
+       write_sysreg(kvm_get_hyp_vector(), vbar_el1);
 }
 
 static void __hyp_text __activate_traps_nvhe(void)
index c8d49879307f75eac9f527fd2343516ecb098d42..2df6a5c42f77c6c83c82ce361555851eb8501213 100644 (file)
@@ -1158,7 +1158,7 @@ static void cpu_init_hyp_mode(void *dummy)
        pgd_ptr = kvm_mmu_get_httbr();
        stack_page = __this_cpu_read(kvm_arm_hyp_stack_page);
        hyp_stack_ptr = stack_page + PAGE_SIZE;
-       vector_ptr = (unsigned long)kvm_ksym_ref(__kvm_hyp_vector);
+       vector_ptr = (unsigned long)kvm_get_hyp_vector();
 
        __cpu_init_hyp_mode(pgd_ptr, hyp_stack_ptr, vector_ptr);
        __cpu_init_stage2();
@@ -1403,6 +1403,12 @@ static int init_hyp_mode(void)
                goto out_err;
        }
 
+       err = kvm_map_vectors();
+       if (err) {
+               kvm_err("Cannot map vectors\n");
+               goto out_err;
+       }
+
        /*
         * Map the Hyp stack pages
         */