realtek: debounce reset key for Zyxel GS1900
authorSander Vanheule <sander@svanheule.net>
Wed, 1 Jan 2025 19:05:20 +0000 (20:05 +0100)
committerSander Vanheule <sander@svanheule.net>
Tue, 14 Jan 2025 09:09:38 +0000 (10:09 +0100)
When the reset button is next to the SFP cages, I2C operations on the
modules might cause interference on the button's GPIO line. Add a
debounce-interval of 5 times the poll-interval to ensure the line is
actually stable for some time and not just glitching.

This squashes commit 4357f32d41eb ("realtek: debounce reset key for
Zyxel GS1900") and commit 777c6106ed4e ("realtek: move debounce-interval
to correct node").

Signed-off-by: Sander Vanheule <sander@svanheule.net>
target/linux/realtek/dts/rtl8380_zyxel_gs1900.dtsi
target/linux/realtek/dts/rtl8393_zyxel_gs1900-48.dts

index b985c4bc8e499df79ff3cde0fe7a422b7242bfb4..3889fe8859a7e3727fe6a7d885a311cc3daf68ab 100644 (file)
@@ -26,6 +26,7 @@
                        label = "reset";
                        gpios = <&gpio1 3 GPIO_ACTIVE_LOW>;
                        linux,code = <KEY_RESTART>;
+                       debounce-interval = <100>;
                };
        };
 
index 9844dc2180ff3645df27e88f9b1ce825b2f79685..a1e0a6d06d82331cd380746c46c90c9c94021781 100644 (file)
                compatible = "gpio-keys-polled";
                poll-interval = <20>;
 
-               mode {
+               reset {
                        label = "reset";
                        gpios = <&gpio1 3 GPIO_ACTIVE_LOW>;
                        linux,code = <KEY_RESTART>;
+                       debounce-interval = <100>;
                };
        };