bridge: mcast: Default back to multicast enabled state
authorIdo Schimmel <idosch@mellanox.com>
Mon, 1 Oct 2018 08:57:01 +0000 (11:57 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 3 Oct 2018 05:27:36 +0000 (22:27 -0700)
Commit 13cefad2f2c1 ("net: bridge: convert and rename mcast disabled")
converted the 'multicast_disabled' field to an option bit named
'BROPT_MULTICAST_ENABLED'.

While the old field was implicitly initialized to 0, the new field is
not initialized, resulting in the bridge defaulting to multicast
disabled state and breaking existing applications.

Fix this by explicitly initializing the option.

Fixes: 13cefad2f2c1 ("net: bridge: convert and rename mcast disabled")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_multicast.c

index 928024d8360d18649b34ba16bd93bf606103917d..024139b51d3a55cdcbb418ec0d11cea5e8e02f02 100644 (file)
@@ -1976,6 +1976,7 @@ void br_multicast_init(struct net_bridge *br)
        br->ip6_other_query.delay_time = 0;
        br->ip6_querier.port = NULL;
 #endif
+       br_opt_toggle(br, BROPT_MULTICAST_ENABLED, true);
        br_opt_toggle(br, BROPT_HAS_IPV6_ADDR, true);
 
        spin_lock_init(&br->multicast_lock);