RDMA/restrack: Make is_visible_in_pid_ns() as an API

Remove is_visible_in_pid_ns() from nldev.c and make it as a restrack API,
so that it can be taken advantage by other parts like counter.

Signed-off-by: Mark Zhang <markz@mellanox.com>
Reviewed-by: Majd Dibbiny <majd@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c
index 5499f5629dc26b1f0a28cafa156444ec290cdd4e..d9ebfb50962beab800f403b86ec77e1b03faa6b5 100644 (file)
--- a/drivers/infiniband/core/nldev.c
+++ b/drivers/infiniband/core/nldev.c
@@ -1002,17 +1002,6 @@ static const struct nldev_fill_res_entry fill_entries[RDMA_RESTRACK_MAX] = {
        },
 };
 
-static bool is_visible_in_pid_ns(struct rdma_restrack_entry *res)
-{
-       /*
-        * 1. Kern resources should be visible in init name space only
-        * 2. Present only resources visible in the current namespace
-        */
-       if (rdma_is_kernel_res(res))
-               return task_active_pid_ns(current) == &init_pid_ns;
-       return task_active_pid_ns(current) == task_active_pid_ns(res->task);
-}
-
 static int res_get_common_doit(struct sk_buff *skb, struct nlmsghdr *nlh,
                               struct netlink_ext_ack *extack,
                               enum rdma_restrack_type res_type)
@@ -1057,7 +1046,7 @@ static int res_get_common_doit(struct sk_buff *skb, struct nlmsghdr *nlh,
                goto err;
        }
 
-       if (!is_visible_in_pid_ns(res)) {
+       if (!rdma_is_visible_in_pid_ns(res)) {
                ret = -ENOENT;
                goto err_get;
        }
@@ -1169,7 +1158,7 @@ static int res_get_common_dumpit(struct sk_buff *skb,
         * objects.
         */
        xa_for_each(&rt->xa, id, res) {
-               if (!is_visible_in_pid_ns(res))
+               if (!rdma_is_visible_in_pid_ns(res))
                        continue;
 
                if (idx < start || !rdma_restrack_get(res))

diff --git a/drivers/infiniband/core/restrack.c b/drivers/infiniband/core/restrack.c
index 3714634ae2967a7b58d62eb12b0d73eb6fdaa7ef..bddff426ee0f0d37dfb32a9e03f97dc9cde7a9ad 100644 (file)
--- a/drivers/infiniband/core/restrack.c
+++ b/drivers/infiniband/core/restrack.c
@@ -349,3 +349,16 @@ out:
        }
 }
 EXPORT_SYMBOL(rdma_restrack_del);
+
+bool rdma_is_visible_in_pid_ns(struct rdma_restrack_entry *res)
+{
+       /*
+        * 1. Kern resources should be visible in init
+        *    namespace only
+        * 2. Present only resources visible in the current
+        *     namespace
+        */
+       if (rdma_is_kernel_res(res))
+               return task_active_pid_ns(current) == &init_pid_ns;
+       return task_active_pid_ns(current) == task_active_pid_ns(res->task);
+}

diff --git a/drivers/infiniband/core/restrack.h b/drivers/infiniband/core/restrack.h
index d084e5f8984911460399af83df0a2447171c42b2..7bd177cc0a6179c635532ed7f718ab432d07a069 100644 (file)
--- a/drivers/infiniband/core/restrack.h
+++ b/drivers/infiniband/core/restrack.h
@@ -27,4 +27,5 @@ int rdma_restrack_init(struct ib_device *dev);
 void rdma_restrack_clean(struct ib_device *dev);
 void rdma_restrack_attach_task(struct rdma_restrack_entry *res,
                               struct task_struct *task);
+bool rdma_is_visible_in_pid_ns(struct rdma_restrack_entry *res);
 #endif /* _RDMA_CORE_RESTRACK_H_ */