[SCSI] qla4xxx: Complete the cmd if sense_len is zero
authorPrasanna Mumbai <prasanna.mumbai@qlogic.com>
Wed, 18 May 2011 06:17:06 +0000 (23:17 -0700)
committerJames Bottomley <jbottomley@parallels.com>
Tue, 24 May 2011 16:39:29 +0000 (12:39 -0400)
Complete the cmd if sense length is zero. For cases where sense
data spans across multiple iocb's by FW, we need to hold on to the
I/O (ha->status_srb != NULL) till we have processed them all and
copied the sense data from internal buffer to scsi_cmd sense buffer.

Signed-off-by: Prasanna Mumbai <prasanna.mumbai@qlogic.com>
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <jbottomley@parallels.com>
drivers/scsi/qla4xxx/ql4_isr.c

index 67d6651cdb36e461bce9febea088bed5aeef400c..0e72921c752d497547e49e59e078aaf38d54bb36 100644 (file)
@@ -25,9 +25,14 @@ static void qla4xxx_copy_sense(struct scsi_qla_host *ha,
 
        memset(cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE);
        sense_len = le16_to_cpu(sts_entry->senseDataByteCnt);
-       if (sense_len == 0)
+       if (sense_len == 0) {
+               DEBUG2(ql4_printk(KERN_INFO, ha, "scsi%ld:%d:%d:%d: %s:"
+                                 " sense len 0\n", ha->host_no,
+                                 cmd->device->channel, cmd->device->id,
+                                 cmd->device->lun, __func__));
+               ha->status_srb = NULL;
                return;
-
+       }
        /* Save total available sense length,
         * not to exceed cmd's sense buffer size */
        sense_len = min_t(uint16_t, sense_len, SCSI_SENSE_BUFFERSIZE);