blk-mq-debugfs: Also show requests that have not yet been started
authorBart Van Assche <bvanassche@acm.org>
Thu, 4 Oct 2018 17:35:24 +0000 (10:35 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 5 Oct 2018 14:16:58 +0000 (08:16 -0600)
When debugging e.g. the SCSI timeout handler it is important that
requests that have not yet been started or that already have
completed are also reported through debugfs.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq-debugfs.c

index a5ea86835fcb2dc2bb7f1a1593637709bce62b2a..41b86f50d1262fff5d8b1939a9eafcec289390b7 100644 (file)
@@ -431,8 +431,7 @@ static void hctx_show_busy_rq(struct request *rq, void *data, bool reserved)
 {
        const struct show_busy_params *params = data;
 
-       if (blk_mq_map_queue(rq->q, rq->mq_ctx->cpu) == params->hctx &&
-           blk_mq_rq_state(rq) != MQ_RQ_IDLE)
+       if (blk_mq_map_queue(rq->q, rq->mq_ctx->cpu) == params->hctx)
                __blk_mq_debugfs_rq_show(params->m,
                                         list_entry_rq(&rq->queuelist));
 }