drm/amd/display: Don't warn when DC update type > DM guess
authorNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Fri, 29 Mar 2019 15:40:43 +0000 (11:40 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 15 Apr 2019 05:21:45 +0000 (00:21 -0500)
[Why]
DM thinks that the update type should be full whenever a stream or
plane is added or removed (including recreations).

This won't match in the case where DC thinks what looks like a fast
update to DM is actually a medium or full - like scaling changes that
affect bandwidth and clocks.

[How]
Drop this warning. DC knows better than the DM does for determining
cases like this.

The other warning can be kept for now since it would warn on a pretty
serious DC or DM bug.

Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: David Francis <David.Francis@amd.com>
Acked-by: Bhawanpreet Lakha <Bhawanpreet Lakha@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 5c0b3bbfd18f5b87848270ff74c47349dba4003d..409979f8bf0bd7ea8e59a8beda82208e2b6b6d7a 100644 (file)
@@ -6600,9 +6600,6 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
         */
        if (lock_and_validation_needed && overall_update_type <= UPDATE_TYPE_FAST)
                WARN(1, "Global lock should be Set, overall_update_type should be UPDATE_TYPE_MED or UPDATE_TYPE_FULL");
-       else if (!lock_and_validation_needed && overall_update_type > UPDATE_TYPE_FAST)
-               WARN(1, "Global lock should NOT be set, overall_update_type should be UPDATE_TYPE_FAST");
-
 
        if (overall_update_type > UPDATE_TYPE_FAST) {
                ret = dm_atomic_get_state(state, &dm_state);