[PATCH] spufs: fix sparse warnings

One local variable is missing an __iomem modifier,
in another place, we pass a completely unused argument
with a missing __user modifier.

Signed-off-by: Arnd Bergmann <arndb@de.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>

diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c
index 081b3dcbaf1405f2a0d30e6797d6f51ddfb6c8cb..7fe3fa3da0e92a92d1e3b8232e693d00e3141e7c 100644 (file)
--- a/arch/powerpc/platforms/cell/spu_base.c
+++ b/arch/powerpc/platforms/cell/spu_base.c
@@ -357,7 +357,7 @@ static void spu_init_channels(struct spu *spu)
                { 0x17, 1, }, { 0x18, 0, }, { 0x19, 0, }, { 0x1b, 0, },
                { 0x1c, 1, }, { 0x1d, 0, }, { 0x1e, 1, },
        };
-       struct spu_priv2 *priv2;
+       struct spu_priv2 __iomem *priv2;
        int i;
 
        priv2 = spu->priv2;

diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
index 687f80d09f416f4bd40e4b51bff3d0a7ee95f7b7..1f3507c75e90068c49a00b2adc66ca72a3cda90e 100644 (file)
--- a/arch/powerpc/platforms/cell/spufs/inode.c
+++ b/arch/powerpc/platforms/cell/spufs/inode.c
@@ -293,9 +293,8 @@ out:
 
 static struct file_system_type spufs_type;
 
-long
-spufs_create_thread(struct nameidata *nd, const char *name,
-                       unsigned int flags, mode_t mode)
+long spufs_create_thread(struct nameidata *nd,
+                        unsigned int flags, mode_t mode)
 {
        struct dentry *dentry;
        int ret;

diff --git a/arch/powerpc/platforms/cell/spufs/spufs.h b/arch/powerpc/platforms/cell/spufs/spufs.h
index c715ed0c4014c86743ae6a4f34813da7f87a9a81..db2601f0abd54db2b3e571bba9c2cb37fa646523 100644 (file)
--- a/arch/powerpc/platforms/cell/spufs/spufs.h
+++ b/arch/powerpc/platforms/cell/spufs/spufs.h
@@ -101,7 +101,7 @@ extern struct tree_descr spufs_dir_contents[];
 /* system call implementation */
 long spufs_run_spu(struct file *file,
                   struct spu_context *ctx, u32 *npc, u32 *status);
-long spufs_create_thread(struct nameidata *nd, const char *name,
+long spufs_create_thread(struct nameidata *nd,
                         unsigned int flags, mode_t mode);
 extern struct file_operations spufs_context_fops;
 

diff --git a/arch/powerpc/platforms/cell/spufs/syscalls.c b/arch/powerpc/platforms/cell/spufs/syscalls.c
index 0c2896ac9518008dcfa04f5b3f7de58bf88f418e..d549aa7ebea6175eefc3c38eefadd189e949211c 100644 (file)
--- a/arch/powerpc/platforms/cell/spufs/syscalls.c
+++ b/arch/powerpc/platforms/cell/spufs/syscalls.c
@@ -85,7 +85,7 @@ asmlinkage long sys_spu_create(const char __user *pathname,
                ret = path_lookup(tmp, LOOKUP_PARENT|
                                LOOKUP_OPEN|LOOKUP_CREATE, &nd);
                if (!ret) {
-                       ret = spufs_create_thread(&nd, pathname, flags, mode);
+                       ret = spufs_create_thread(&nd, flags, mode);
                        path_release(&nd);
                }
                putname(tmp);