cifs: set oparms.create_options rather than or'ing in CREATE_OPEN_BACKUP_INTENT
authorColin Ian King <colin.king@canonical.com>
Wed, 5 Jul 2017 12:47:34 +0000 (13:47 +0100)
committerSteve French <smfrench@gmail.com>
Thu, 6 Jul 2017 01:01:22 +0000 (20:01 -0500)
Currently oparms.create_options is uninitialized and the code is logically
or'ing in CREATE_OPEN_BACKUP_INTENT onto a garbage value of
oparms.create_options from the stack.  Fix this by just setting the value
rather than or'ing in the setting.

Detected by CoverityScan, CID#1447220 ("Unitialized scale value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
fs/cifs/smb2ops.c

index 323bafdd790942260c378ba96c62e189d6a9b9a0..ccbb397debbc28238d85d39583098e1805a5de16 100644 (file)
@@ -1339,7 +1339,7 @@ get_smb2_acl_by_path(struct cifs_sb_info *cifs_sb,
        xid = get_xid();
 
        if (backup_cred(cifs_sb))
-               oparms.create_options |= CREATE_OPEN_BACKUP_INTENT;
+               oparms.create_options = CREATE_OPEN_BACKUP_INTENT;
        else
                oparms.create_options = 0;