liquidio: Use zeroing memory allocator than allocator/memset
authorHimanshu Jha <himanshujha199640@gmail.com>
Sun, 31 Dec 2017 12:27:29 +0000 (17:57 +0530)
committerDavid S. Miller <davem@davemloft.net>
Wed, 3 Jan 2018 03:01:27 +0000 (22:01 -0500)
Use vzalloc for allocating zeroed memory and remove unnecessary
memset function.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.

Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cavium/liquidio/octeon_device.c

index 2c615ab09e6480bbba4e81f5a8777eaedc997e15..f38abf6264122016ff704520400a38618477a114 100644 (file)
@@ -702,12 +702,10 @@ static struct octeon_device *octeon_allocate_device_mem(u32 pci_id,
        size = octdevsize + priv_size + configsize +
                (sizeof(struct octeon_dispatch) * DISPATCH_LIST_SIZE);
 
-       buf = vmalloc(size);
+       buf = vzalloc(size);
        if (!buf)
                return NULL;
 
-       memset(buf, 0, size);
-
        oct = (struct octeon_device *)buf;
        oct->priv = (void *)(buf + octdevsize);
        oct->chip = (void *)(buf + octdevsize + priv_size);
@@ -840,10 +838,9 @@ octeon_allocate_ioq_vector(struct octeon_device  *oct)
 
        size = sizeof(struct octeon_ioq_vector) * num_ioqs;
 
-       oct->ioq_vector = vmalloc(size);
+       oct->ioq_vector = vzalloc(size);
        if (!oct->ioq_vector)
                return 1;
-       memset(oct->ioq_vector, 0, size);
        for (i = 0; i < num_ioqs; i++) {
                ioq_vector              = &oct->ioq_vector[i];
                ioq_vector->oct_dev     = oct;