pppoe: fix /proc/net/pppoe
authorEric Dumazet <eric.dumazet@gmail.com>
Tue, 28 Jul 2009 23:43:08 +0000 (23:43 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 30 Jul 2009 21:19:19 +0000 (14:19 -0700)
If a socket is hashed in last slot of pppoe hash table (PPPOE_HASH_SIZE-1)
we report it many times (up to filling seq buffer)
(Only the last socket of last slot)

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/pppoe.c

index f0031f1f97e5e1b7bd52d825021fa3783c93885a..5f2090233d7bd8ba3eb6a82fa8613db0f29f6348 100644 (file)
@@ -1063,6 +1063,7 @@ static void *pppoe_seq_next(struct seq_file *seq, void *v, loff_t *pos)
        else {
                int hash = hash_item(po->pppoe_pa.sid, po->pppoe_pa.remote);
 
+               po = NULL;
                while (++hash < PPPOE_HASH_SIZE) {
                        po = pn->hash_table[hash];
                        if (po)