gpio: selftests: gpio-mockup-chardev GPIOHANDLE_REQUEST_OUTPUT fix

Following logic from commit: 22f6592b23, GPIOHANDLE_REQUEST_OUTPUT
should handle errors same way as GPIOHANDLE_REQUEST_INPUT does, or else
the following error occurs:

gpio-mockup-chardev: gpio<gpiochip1> line<0> test flag<0x2> value<0>: No
such file or directory

despite the real result of gpio_pin_test(), gpio_debugfs_get() and
gpiotools_request_linehandle() functions.

Signed-off-by: Rafael David Tinoco <rafael.tinoco@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/tools/testing/selftests/gpio/gpio-mockup-chardev.c b/tools/testing/selftests/gpio/gpio-mockup-chardev.c
index 667e916fa7cc1805e3bf6ddff301e1da24d4bda7..f8d468f54e986dd00aa82ba1aa29370896f656ee 100644 (file)
--- a/tools/testing/selftests/gpio/gpio-mockup-chardev.c
+++ b/tools/testing/selftests/gpio/gpio-mockup-chardev.c
@@ -225,10 +225,10 @@ int gpio_pin_test(struct gpiochip_info *cinfo, int line, int flag, int value)
                if (flag & GPIOHANDLE_REQUEST_ACTIVE_LOW)
                        debugfs_value = !debugfs_value;
 
-               if (!(debugfs_dir == OUT && value == debugfs_value))
+               if (!(debugfs_dir == OUT && value == debugfs_value)) {
                        errno = -EINVAL;
-               ret = -errno;
-
+                       ret = -errno;
+               }
        }
        gpiotools_release_linehandle(fd);