projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1635bb5
)
net: usb: remove redundant null pointer check before of_node_put
author
zhong jiang
<zhongjiang@huawei.com>
Sun, 16 Sep 2018 13:20:17 +0000
(21:20 +0800)
committer
David S. Miller
<davem@davemloft.net>
Mon, 17 Sep 2018 15:20:11 +0000
(08:20 -0700)
of_node_put has taken the null pointer check into account. So it is
safe to remove the duplicated check before of_node_put.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/lan78xx.c
patch
|
blob
|
history
diff --git
a/drivers/net/usb/lan78xx.c
b/drivers/net/usb/lan78xx.c
index 95a98a20b2e35a824e34139cc202e569f8bfd91a..04f0a094d864f23c34366cc93ec186bb23d180f5 100644
(file)
--- a/
drivers/net/usb/lan78xx.c
+++ b/
drivers/net/usb/lan78xx.c
@@
-1835,8
+1835,7
@@
static int lan78xx_mdio_init(struct lan78xx_net *dev)
node = of_get_child_by_name(dev->udev->dev.of_node, "mdio");
ret = of_mdiobus_register(dev->mdiobus, node);
- if (node)
- of_node_put(node);
+ of_node_put(node);
if (ret) {
netdev_err(dev->net, "can't register MDIO bus\n");
goto exit1;