wifi-scripts: don't fail on unset PSK
authorDavid Bauer <mail@david-bauer.net>
Sat, 7 Dec 2024 13:47:29 +0000 (14:47 +0100)
committerJohn Crispin <john@phrozen.org>
Fri, 13 Dec 2024 14:29:03 +0000 (15:29 +0100)
Don't fail wireless interface bringup on empty PSK set. This is a valid
configuration, resulting in a PSK network which can't be connected to.
It does not fail the bringup of the hostapd process.

Keep failing the interface setup in case a password with invalid length
is used.

This is also beneficial when intending to configure a PPSK network. It
allows to create a network where no PPSK is yet set.

Signed-off-by: David Bauer <mail@david-bauer.net>
Link: https://github.com/openwrt/openwrt/pull/17197
Signed-off-by: John Crispin <john@phrozen.org>
package/network/config/wifi-scripts/files/lib/netifd/hostapd.sh

index 3285ee4312f37d356d06de8224e26c3d04a25ab9..080f15d7a6579ec043bda4bd36aaa5f5266931e2 100644 (file)
@@ -724,7 +724,7 @@ hostapd_set_bss_options() {
                                append bss_conf "wpa_psk=$key" "$N"
                        elif [ ${#key} -ge 8 ] && [ ${#key} -le 63 ]; then
                                append bss_conf "wpa_passphrase=$key" "$N"
-                       elif [ -n "$key" ] || [ -z "$wpa_psk_file" ] || [ -z "$sae_password_file" ]; then
+                       elif [ -n "$key" ]; then
                                wireless_setup_vif_failed INVALID_WPA_PSK
                                return 1
                        fi