powerpc: Make default kexec/crash_kernel ops implicit
authorAnton Vorontsov <avorontsov@ru.mvista.com>
Tue, 16 Dec 2008 06:23:05 +0000 (06:23 +0000)
committerPaul Mackerras <paulus@samba.org>
Tue, 23 Dec 2008 04:13:28 +0000 (15:13 +1100)
This removes the need for each platform to specify default kexec and
crash kernel ops, thus effectively adds a working kexec support for
most 6xx/7xx/7xxx-based boards.

Platforms that can't cope with default ops will explode in some weird
way (a hang or reboot is most likely), which means that the board's
kexec support should be fixed or blacklisted via dummy _prepare
callback returning -ENOSYS.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/kernel/machine_kexec.c

index 037ade74a99ec4f3a6ba22f9ef40741b1fe593ce..4f797c0b7148b83fbf2db213eecfa362d7272e75 100644 (file)
@@ -22,6 +22,8 @@ void machine_crash_shutdown(struct pt_regs *regs)
 {
        if (ppc_md.machine_crash_shutdown)
                ppc_md.machine_crash_shutdown(regs);
+       else
+               default_machine_crash_shutdown(regs);
 }
 
 /*
@@ -33,11 +35,8 @@ int machine_kexec_prepare(struct kimage *image)
 {
        if (ppc_md.machine_kexec_prepare)
                return ppc_md.machine_kexec_prepare(image);
-       /*
-        * Fail if platform doesn't provide its own machine_kexec_prepare
-        * implementation.
-        */
-       return -ENOSYS;
+       else
+               return default_machine_kexec_prepare(image);
 }
 
 void machine_kexec_cleanup(struct kimage *image)
@@ -54,13 +53,11 @@ void machine_kexec(struct kimage *image)
 {
        if (ppc_md.machine_kexec)
                ppc_md.machine_kexec(image);
-       else {
-               /*
-                * Fall back to normal restart if platform doesn't provide
-                * its own kexec function, and user insist to kexec...
-                */
-               machine_restart(NULL);
-       }
+       else
+               default_machine_kexec(image);
+
+       /* Fall back to normal restart if we're still alive. */
+       machine_restart(NULL);
        for(;;);
 }