drm/i915/guc: Rename intel_guc_is_alive to intel_guc_is_loaded
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Wed, 22 May 2019 19:31:58 +0000 (19:31 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 23 May 2019 20:58:36 +0000 (21:58 +0100)
This function just check our software flag, while 'is_alive'
may suggest that we are checking runtime firmware status.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20190522193203.23932-5-michal.wajdeczko@intel.com
drivers/gpu/drm/i915/intel_guc.h
drivers/gpu/drm/i915/intel_guc_submission.c

index 2494e84831a2d4a4d4764f3cd03504ef34290501..d4b015ab8a36370c7e3a796383fc225132b41d1b 100644 (file)
@@ -96,11 +96,6 @@ struct intel_guc {
        void (*notify)(struct intel_guc *guc);
 };
 
-static inline bool intel_guc_is_alive(struct intel_guc *guc)
-{
-       return intel_uc_fw_is_loaded(&guc->fw);
-}
-
 static
 inline int intel_guc_send(struct intel_guc *guc, const u32 *action, u32 len)
 {
@@ -176,6 +171,11 @@ u32 intel_guc_reserved_gtt_size(struct intel_guc *guc);
 int intel_guc_reserve_ggtt_top(struct intel_guc *guc);
 void intel_guc_release_ggtt_top(struct intel_guc *guc);
 
+static inline bool intel_guc_is_loaded(struct intel_guc *guc)
+{
+       return intel_uc_fw_is_loaded(&guc->fw);
+}
+
 static inline int intel_guc_sanitize(struct intel_guc *guc)
 {
        intel_uc_fw_sanitize(&guc->fw);
index ea0e3734d37c6eef83168bdb92a75a8cf9a12e67..987ff586d7f9e0e4c1b9ac63a0c70573f3e009fc 100644 (file)
@@ -1199,7 +1199,7 @@ static void __guc_client_disable(struct intel_guc_client *client)
         * the case, instead of trying (in vain) to communicate with it, let's
         * just cleanup the doorbell HW and our internal state.
         */
-       if (intel_guc_is_alive(client->guc))
+       if (intel_guc_is_loaded(client->guc))
                destroy_doorbell(client);
        else
                __fini_doorbell(client);