media: exynos4-is: make array 'cmd' static, shrinks object size
authorColin Ian King <colin.king@canonical.com>
Sat, 6 Jan 2018 16:03:27 +0000 (11:03 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 6 Mar 2018 11:05:12 +0000 (06:05 -0500)
Don't populate the const read-only array 'cmd' on the stack but instead
make it static. Makes the object code smaller by 38 bytes:

Before:
   text    data     bss     dec     hex filename
   4950     868       0    5818    16ba fimc-is-regs.o

After:
   text    data     bss     dec     hex filename
   4824     956       0    5780    1694 fimc-is-regs.o

(gcc version 7.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/exynos4-is/fimc-is-regs.c

index cfe4406a83ffc0fc3e7fca6dd03cee84a9f3838b..e0e2910660375ca57233cb88b55b9d37a3446bf3 100644 (file)
@@ -159,7 +159,7 @@ void fimc_is_hw_load_setfile(struct fimc_is *is)
 
 int fimc_is_hw_change_mode(struct fimc_is *is)
 {
-       const u8 cmd[] = {
+       static const u8 cmd[] = {
                HIC_PREVIEW_STILL, HIC_PREVIEW_VIDEO,
                HIC_CAPTURE_STILL, HIC_CAPTURE_VIDEO,
        };