drm/bochs: switch to generic drm fbdev emulation
authorGerd Hoffmann <kraxel@redhat.com>
Fri, 11 Jan 2019 05:37:50 +0000 (06:37 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 14 Jan 2019 07:39:15 +0000 (08:39 +0100)
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20190111053752.4004-15-kraxel@redhat.com
drivers/gpu/drm/bochs/bochs_drv.c

index a3f4e21078ed6abb1afe3633c88cd146d8a727ac..cea42ac64d7e952c413bf06bbdd5dc6a538e7c50 100644 (file)
@@ -16,10 +16,6 @@ static int bochs_modeset = -1;
 module_param_named(modeset, bochs_modeset, int, 0444);
 MODULE_PARM_DESC(modeset, "enable/disable kernel modesetting");
 
-static bool enable_fbdev = true;
-module_param_named(fbdev, enable_fbdev, bool, 0444);
-MODULE_PARM_DESC(fbdev, "register fbdev device");
-
 /* ---------------------------------------------------------------------- */
 /* drm interface                                                          */
 
@@ -27,7 +23,6 @@ static void bochs_unload(struct drm_device *dev)
 {
        struct bochs_device *bochs = dev->dev_private;
 
-       bochs_fbdev_fini(bochs);
        bochs_kms_fini(bochs);
        bochs_mm_fini(bochs);
        bochs_hw_fini(dev);
@@ -58,9 +53,6 @@ static int bochs_load(struct drm_device *dev)
        if (ret)
                goto err;
 
-       if (enable_fbdev)
-               bochs_fbdev_init(bochs);
-
        return 0;
 
 err:
@@ -110,9 +102,7 @@ static int bochs_pm_suspend(struct device *dev)
 {
        struct pci_dev *pdev = to_pci_dev(dev);
        struct drm_device *drm_dev = pci_get_drvdata(pdev);
-       struct bochs_device *bochs = drm_dev->dev_private;
 
-       drm_fb_helper_set_suspend_unlocked(&bochs->fb.helper, 1);
        return drm_mode_config_helper_suspend(drm_dev);
 }
 
@@ -120,9 +110,7 @@ static int bochs_pm_resume(struct device *dev)
 {
        struct pci_dev *pdev = to_pci_dev(dev);
        struct drm_device *drm_dev = pci_get_drvdata(pdev);
-       struct bochs_device *bochs = drm_dev->dev_private;
 
-       drm_fb_helper_set_suspend_unlocked(&bochs->fb.helper, 0);
        return drm_mode_config_helper_resume(drm_dev);
 }
 #endif
@@ -167,6 +155,7 @@ static int bochs_pci_probe(struct pci_dev *pdev,
        if (ret)
                goto err_unload;
 
+       drm_fbdev_generic_setup(dev, 32);
        return ret;
 
 err_unload: