dql: make dql_init return void
authorStephen Hemminger <stephen@networkplumber.org>
Wed, 18 Oct 2017 00:16:52 +0000 (17:16 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 19 Oct 2017 12:33:51 +0000 (13:33 +0100)
dql_init always returned 0, and the only place that uses it
in network core code didn't care about the return value anyway.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Acked-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/dynamic_queue_limits.h
lib/dynamic_queue_limits.c

index a4be70398ce1b2cb192a7b3bed9477439b2e3c57..f69f98541953570bd604df83f4a8cb4f4e1bec66 100644 (file)
@@ -98,7 +98,7 @@ void dql_completed(struct dql *dql, unsigned int count);
 void dql_reset(struct dql *dql);
 
 /* Initialize dql state */
-int dql_init(struct dql *dql, unsigned hold_time);
+void dql_init(struct dql *dql, unsigned int hold_time);
 
 #endif /* _KERNEL_ */
 
index f346715e22557599c796ccd17cdc610a8232de4e..dbe61c4c2a97f0b96e2b265f24fdd252ab005478 100644 (file)
@@ -127,12 +127,11 @@ void dql_reset(struct dql *dql)
 }
 EXPORT_SYMBOL(dql_reset);
 
-int dql_init(struct dql *dql, unsigned hold_time)
+void dql_init(struct dql *dql, unsigned int hold_time)
 {
        dql->max_limit = DQL_MAX_LIMIT;
        dql->min_limit = 0;
        dql->slack_hold_time = hold_time;
        dql_reset(dql);
-       return 0;
 }
 EXPORT_SYMBOL(dql_init);