IB/srp: Use print_hex_dump()
authorBart Van Assche <bvanassche@acm.org>
Thu, 29 Jul 2010 15:56:37 +0000 (15:56 +0000)
committerRoland Dreier <rolandd@cisco.com>
Wed, 4 Aug 2010 18:24:12 +0000 (11:24 -0700)
Replace an open-coded dump of the receive buffer with a call to
print_hex_dump().

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/ulp/srp/ib_srp.c

index ed3f9ebae882b880e8446e5e572ad8600019c796..4675defb374c22b0e4cf4e3341ce7e24ac90e841 100644 (file)
@@ -879,21 +879,10 @@ static void srp_handle_recv(struct srp_target_port *target, struct ib_wc *wc)
        opcode = *(u8 *) iu->buf;
 
        if (0) {
-               int i;
-
                shost_printk(KERN_ERR, target->scsi_host,
                             PFX "recv completion, opcode 0x%02x\n", opcode);
-
-               for (i = 0; i < wc->byte_len; ++i) {
-                       if (i % 8 == 0)
-                               printk(KERN_ERR "  [%02x] ", i);
-                       printk(" %02x", ((u8 *) iu->buf)[i]);
-                       if ((i + 1) % 8 == 0)
-                               printk("\n");
-               }
-
-               if (wc->byte_len % 8)
-                       printk("\n");
+               print_hex_dump(KERN_ERR, "", DUMP_PREFIX_OFFSET, 8, 1,
+                              iu->buf, wc->byte_len, true);
        }
 
        switch (opcode) {